Skip to content

Commit

Permalink
[dagster-airlift] Add python 3.8 support (#25151)
Browse files Browse the repository at this point in the history
## Summary & Motivation
In order to support 3.8, we need to place an upper bound on boto3 (older versions don't have access to mwaa).
The version I chose is quite old, I don't anticipate this causing a problem. I guess with some resolvers it chooses a version pre-mwaa though, as that's why the tests were failing.
## How I Tested These Changes
Tests now run on 3.8
## Changelog
NOCHANGELOG
  • Loading branch information
dpeng817 authored Oct 10, 2024
1 parent 6a49a39 commit af5df3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,6 @@ def k8s_extra_cmds(version: str, _) -> List[str]:
PackageSpec(
"examples/experimental/dagster-airlift",
unsupported_python_versions=[
AvailablePythonVersion.V3_8,
AvailablePythonVersion.V3_12,
],
),
Expand Down
4 changes: 3 additions & 1 deletion examples/experimental/dagster-airlift/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ def get_version() -> str:
f"dagster{pin}",
],
"in-airflow": airflow_dep_list,
"mwaa": ["boto3"],
"mwaa": [
"boto3>=1.18.0"
], # confirms that mwaa is available in the environment (can't find exactly which version adds mwaa support, but I can confirm that 1.18.0 and greater have it.)
"dbt": ["dagster-dbt"],
"k8s": ["dagster-k8s"],
"test": ["pytest", "dagster-dbt", "dbt-duckdb", "boto3", "dagster-webserver"],
Expand Down

0 comments on commit af5df3e

Please sign in to comment.