Skip to content

Commit

Permalink
Setup GTM correctly (#22547)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Actually install GTM

## How I Tested These Changes
idk, just doing what nextjs said to do:
<img width="880" alt="Screenshot 2024-06-13 at 6 34 58 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/c960a52c-84f4-4cc1-945b-6682e2241c77">
  • Loading branch information
salazarm committed Jun 13, 2024
1 parent 5925de7 commit b030d25
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 0 deletions.
1 change: 1 addition & 0 deletions docs/next/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"@markdoc/next.js": "^0.2.2",
"@mdx-js/loader": "^1.6.22",
"@next/mdx": "^12.2.2",
"@next/third-parties": "^14.2.4",
"@tailwindcss/forms": "^0.2.1",
"@tailwindcss/typography": "^0.4.0",
"@types/mdx": "^2.0.2",
Expand Down
2 changes: 2 additions & 0 deletions docs/next/pages/_document.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import {GoogleTagManager} from '@next/third-parties/google';
import Document, {Head, Html, Main, NextScript} from 'next/document';

import {GA_TRACKING_ID} from '../util/gtag';
Expand All @@ -9,6 +10,7 @@ export default class MyDocument extends Document {
<Head>
{process.env.NODE_ENV === 'production' && (
<>
<GoogleTagManager gtmId="GTM-T87Z967J" />
{/* Global Site Tag (gtag.js) - Google Analytics */}
<script async src={`https://www.googletagmanager.com/gtag/js?id=${GA_TRACKING_ID}`} />
<script
Expand Down
20 changes: 20 additions & 0 deletions docs/next/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2341,6 +2341,18 @@ __metadata:
languageName: node
linkType: hard

"@next/third-parties@npm:^14.2.4":
version: 14.2.4
resolution: "@next/third-parties@npm:14.2.4"
dependencies:
third-party-capital: 1.0.20
peerDependencies:
next: ^13.0.0 || ^14.0.0
react: ^18.2.0
checksum: 3c5bda0786892927d3e2dc9a30dfc2f43c5118b2ae73b35bbc8321eeaf1431ed511fe0388ca443dd3c7f27fd0b22353e15388292c89d74320cb0b9ecaab32deb
languageName: node
linkType: hard

"@nodelib/fs.scandir@npm:2.1.5":
version: 2.1.5
resolution: "@nodelib/fs.scandir@npm:2.1.5"
Expand Down Expand Up @@ -4561,6 +4573,7 @@ __metadata:
"@markdoc/next.js": ^0.2.2
"@mdx-js/loader": ^1.6.22
"@next/mdx": ^12.2.2
"@next/third-parties": ^14.2.4
"@tailwindcss/forms": ^0.2.1
"@tailwindcss/jit": ^0.1.1
"@tailwindcss/typography": ^0.4.0
Expand Down Expand Up @@ -11419,6 +11432,13 @@ __metadata:
languageName: node
linkType: hard

"third-party-capital@npm:1.0.20":
version: 1.0.20
resolution: "third-party-capital@npm:1.0.20"
checksum: ef5eae00bdb82b538b9f628a011fc294cd6f4bafdbb46d88f3d1a72e8c3b9e2cc2a547fdb62bc16bdd847e9da3dac2df676b154c64914f6c90ea15aac6ce0a6a
languageName: node
linkType: hard

"throttle-debounce@npm:^3.0.1":
version: 3.0.1
resolution: "throttle-debounce@npm:3.0.1"
Expand Down

1 comment on commit b030d25

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-o23osadeg-elementl.vercel.app

Built with commit b030d25.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.