Skip to content

Commit

Permalink
[docs] increase admonition padding to 4 all around (#19993)
Browse files Browse the repository at this point in the history
## Summary & Motivation

This is definitely a nitpick, but currentnotes & warnings are rather
skinny vertically, and I believe they would be slightly more
aesthetically pleasing if we used `p-4` instead of `px-4`.

This is definitely personal preference - would be curious what others
think.

### Examples

**Before**
<img width="1262" alt="image"
src="https://github.com/dagster-io/dagster/assets/5807118/161f5807-c3af-40af-b11f-36605771384a">

**After**
<img width="1226" alt="image"
src="https://github.com/dagster-io/dagster/assets/5807118/865f5966-46db-42f0-a5b2-9229208bce0c">
  • Loading branch information
cmpadden authored Feb 23, 2024
1 parent ecba104 commit b6cd6e3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/next/components/markdoc/Callouts.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const ADMONITION_STYLES = {
const Admonition = ({style, children}) => {
const {colors, icon} = ADMONITION_STYLES[style];
return (
<div className={`bg-${colors.bg} border-l-4 border-${colors.borderIcon} px-4 my-4`}>
<div className={`bg-${colors.bg} border-l-4 border-${colors.borderIcon} p-4 my-4`}>
<div className="flex items-center">
<div className="flex-shrink-0">
<svg
Expand Down

1 comment on commit b6cd6e3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagster-docs ready!

✅ Preview
https://dagster-docs-71i8ie7lo-elementl.vercel.app
https://master.dagster.dagster-docs.io

Built with commit b6cd6e3.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.