Skip to content

Commit

Permalink
[docs-beta] Add Vale updates (#23785)
Browse files Browse the repository at this point in the history
Brings in #23754 and #23758 into the master branch for docs-beta
styling.

---------

Co-authored-by: Erin Cochran <[email protected]>
  • Loading branch information
PedramNavid and erinkcochran87 committed Aug 21, 2024
1 parent 696143d commit c5ced28
Show file tree
Hide file tree
Showing 9 changed files with 17,881 additions and 36 deletions.
11 changes: 11 additions & 0 deletions .github/workflows/build-docs-revamp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@ jobs:
- name: Checkout docs/revamp branch
uses: actions/checkout@v4

- name: Install node
uses: actions/setup-node@v4
with:
node-version: 18

- name: Run Linting
run: |
cd docs/docs-beta
yarn install
yarn run lint
- name: Publish Preview to Vercel
uses: amondnet/vercel-action@v25
with:
Expand Down
Binary file modified docs/docs-beta/.yarn/install-state.gz
Binary file not shown.
36 changes: 15 additions & 21 deletions docs/docs-beta/content-templates/concept.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,49 +5,47 @@ description: ''

# [TOPIC]

<!-- This section is an intro that includes:
This section is an intro that includes:

- A brief description of what the topic is,
- An example of how it could be used in the real-world
- What it can do in the UI
-->

---

## Benefits

<!-- This section lists the benefits of using the topic, whatever it is. The items listed here should be solutions to real-world problems that the user cares about, ex:
This section lists the benefits of using the topic, whatever it is. The items listed here should be solutions to real-world problems that the user cares about, ex:

Using schedules helps you:

- Predictably process and deliver data to stakeholders and business-critical applications
- Consistently run data pipelines without the need for manual intervention
- Optimize resource usage by scheduling pipelines to run during off-peak hours
-->

Using [TOPIC] helps you:

<!-- - A benefit of the thing
- A benefit of the thing
- Another benefit
- And one more -->
- And one more

---

## Prerequisites

<!-- This section lists the prerequisites users must complete before they should/can proceed. For concepts, we should list the other concepts they should be familiar with first. -->
This section lists the prerequisites users must complete before they should/can proceed. For concepts, we should list the other concepts they should be familiar with first.

Before continuing, you should be familiar with:

<!-- - Ex: To use asset checks, users should understand Asset definitions first
- Ex: To use asset checks, users should understand Asset definitions first
- Another one
- One more -->
- One more

---

## How it works

<!-- This section provides a high-level overview of how the concept works without getting too into the technical details. Code can be shown here, but this section shouldn't focus on it. The goal is to help the user generally understand how the thing works and what they need to do to get it working without overwhelming them with details.
This section provides a high-level overview of how the concept works without getting too into the technical details. Code can be shown here, but this section shouldn't focus on it. The goal is to help the user generally understand how the thing works and what they need to do to get it working without overwhelming them with details.

For example, this is the How it works for Schedules:

Expand All @@ -57,40 +55,36 @@ Schedules run jobs at fixed time intervals and have two main components:

- A cron expression, which defines when the schedule runs. Simple and complex schedules are supported, allowing you to have fine-grained control over when runs are executed. With cron syntax, you can:

- Create custom schedules like Every hour from 9:00AM - 5:00PM with cron expressions (0 9-17 * * *)
- Quickly create basic schedules like Every day at midnight with predefined cron definitions (@daily, @midnight)
- Create custom schedules like Every hour from 9:00AM - 5:00PM with cron expressions (0 9-17 \* \* \*)
- Quickly create basic schedules like Every day at midnight with predefined cron definitions (@daily, @midnight)

To make creating cron expressions easier, you can use an online tool like Crontab Guru. This tool allows you to create and describe cron expressions in a human-readable format and test the execution dates produced by the expression. Note: While this tool is useful for general cron expression testing, always remember to test your schedules in Dagster to ensure the results are as expected.
To make creating cron expressions easier, you can use an online tool like Crontab Guru. This tool allows you to create and describe cron expressions in a human-readable format and test the execution dates produced by the expression. Note: While this tool is useful for general cron expression testing, always remember to test your schedules in Dagster to ensure the results are as expected.

For a schedule to run, it must be turned on and an active dagster-daemon process must be running. If you used dagster dev to start the Dagster UI/webserver, the daemon process will be automatically launched alongside the webserver.

After these criteria are met, the schedule will run at the interval specified in the cron expression. Schedules will execute in UTC by default, but you can specify a custom timezone.

-->

---

## Getting started

<!-- This section is a list of guides / links to pages to help the user get started using the topic. -->
This section is a list of guides / links to pages to help the user get started using the topic.

Check out these guides to get started with [CONCEPT]:

From here, you can:

<!-- A list of things the user can do once they've got the basics down. These could be links to additional guides, ex:
- Construct schedules to run partitioned jobs
- Execute jobs in specific timezones
- Learn to test your schedules
- Identify and resolve common issues with our troubleshooting guide -->
- Identify and resolve common issues with our troubleshooting guide

### Limitations [and notes]

<!-- This section should describe any known limitations that could impact the user, ex: "Schedules will execute in UTC unless a timezone is specified" -->
This section should describe any known limitations that could impact the user, ex: "Schedules will execute in UTC unless a timezone is specified"

---

## Related

<!-- A list of related links and resources -->
A list of related links and resources
8 changes: 1 addition & 7 deletions docs/docs-beta/content-templates/example-reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@ This reference contains a variety of examples using Dagster [TOPIC]. Each exampl
- Links to relevant documentation
- A list of the APIs used in the example

---

## [Title of example]

[This example demonstrates [description of what the example accomplishes]

<!-- Example: This example demonstrates how to use resources in schedules. To specify a resource dependency, annotate the resource as a parameter to the schedule's function. -->
Example: This example demonstrates how to use resources in schedules. To specify a resource dependency, annotate the resource as a parameter to the schedule's function.

```python title="my_schedule.py"
@schedule(job=my_job, cron_schedule="* * * * *")
Expand All @@ -27,8 +25,6 @@ def logs_then_skips(context):
return SkipReason("Nothing to do")
```

<!-- We need to fix the base table implemenatation before launch. This is a must. -->

| | |
| -------------------- | --- |
| Notes | |
Expand All @@ -37,8 +33,6 @@ def logs_then_skips(context):

---

<!-- This section lists a few additional sources of inspiration, such as DOP and GitHub discussions. You shouldn't need to change anything here. -->

import InspirationList from '../partials/\_InspirationList.md';

<InspirationList />
8 changes: 4 additions & 4 deletions docs/docs-beta/content-templates/guide-with-steps.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@ To follow the steps in this guide, you'll need:

</details>

## Step 1: Title that describes what this step will do {#step-1}
## Step 1: Title that describes what this step will do

For section / step headings:

- Titles should describe an action, ex: "Generate a token"
- Don't use gerunds (-ing) in titles, as it can cause issues with translation + SEO
- Each section heading should have an identifier that includes the word 'step' and the number of the step, ex: {#step-1}
- Each section heading should have an identifier that includes the word 'step' and the number of the step

### Step 1.1: Title that describes a substep {#step-1-1}
### Step 1.1: Title that describes a substep

If a step would benefit by being broken into smaller steps, follow this section's formatting
Each substep should get an H3 and start with Step N., followed by the number of the substep

## Step 2: Another step {#step-2}
## Step 2: Another step

## Next steps

Expand Down
2 changes: 1 addition & 1 deletion docs/docs-beta/docusaurus.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const config: Config = {
baseUrl: '/',
onBrokenLinks: 'throw',
onBrokenMarkdownLinks: 'throw',
onBrokenAnchors: 'throw',
onBrokenAnchors: 'throw',
organizationName: 'dagster',
projectName: 'dagster',
markdown: {
Expand Down
Loading

0 comments on commit c5ced28

Please sign in to comment.