fix types

dagster-io · Sep 19, 2023 · cdfb192 · cdfb192
1 parent 4e5d4ba
commit cdfb192
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 10 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsCatalogRoot.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetsCatalogRoot.tsx
@@ -65,7 +65,6 @@ export const AssetsCatalogRoot = () => {
           assetKey={{path: currentPath}}
           right={
             <Box flex={{gap: 12, alignItems: 'center'}}>
-              <AssetGlobalLineageLink />
               <ReloadAllButton label="Reload definitions" />
             </Box>
           }

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/LogsToolbar.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/LogsToolbar.tsx
@@ -44,15 +44,17 @@ interface ILogsToolbarProps {
   computeLogUrl: string | null;
 
   children?: React.ReactNode;
+}
 
+interface WithExpandCollapseProps extends ILogsToolbarProps {
   isSectionExpanded: boolean;
   toggleExpanded: () => void;
 }
 
 const logQueryToString = (logQuery: LogFilterValue[]) =>
   logQuery.map(({token, value}) => (token ? `${token}:${value}` : value)).join(' ');
 
-export const LogsToolbar: React.FC<ILogsToolbarProps> = (props) => {
+export const LogsToolbar: React.FC<ILogsToolbarProps | WithExpandCollapseProps> = (props) => {
   const {
     steps,
     metadata,
@@ -64,10 +66,15 @@ export const LogsToolbar: React.FC<ILogsToolbarProps> = (props) => {
     computeLogFileKey,
     onSetComputeLogKey,
     computeLogUrl,
-    isSectionExpanded,
-    toggleExpanded,
     children,
   } = props;
+  let isSectionExpanded;
+  let toggleExpanded;
+
+  if ('isSectionExpanded' in props) {
+    isSectionExpanded = props.isSectionExpanded;
+    toggleExpanded = props.toggleExpanded;
+  }
 
   const activeItems = React.useMemo(() => new Set([logType]), [logType]);
 
@@ -101,12 +108,14 @@ export const LogsToolbar: React.FC<ILogsToolbarProps> = (props) => {
         />
       )}
       {children}
-      <Tooltip content={isSectionExpanded ? 'Collapse' : 'Expand'}>
-        <Button
-          icon={<Icon name={isSectionExpanded ? 'collapse_arrows' : 'expand_arrows'} />}
-          onClick={toggleExpanded}
-        />
-      </Tooltip>
+      {toggleExpanded ? (
+        <Tooltip content={isSectionExpanded ? 'Collapse' : 'Expand'}>
+          <Button
+            icon={<Icon name={isSectionExpanded ? 'collapse_arrows' : 'expand_arrows'} />}
+            onClick={toggleExpanded}
+          />
+        </Tooltip>
+      ) : null}
     </OptionsContainer>
   );
 };