Skip to content

Commit

Permalink
[ui] add more detail in launch multiple runs' error text (#26409)
Browse files Browse the repository at this point in the history
## Summary & Motivation
Previous error message was not clear to users when their "Launch all
runs" operation fails due to ill-defined RunRequests. The feature
requires RunRequests having job_name defined which is optional:

https://github.com/dagster-io/dagster/blob/54b39a2595408ae723e77830919fc3219f268c70/python_modules/dagster/dagster/_core/definitions/run_request.py#L81

## How I Tested These Changes
Tested locally
  • Loading branch information
dliu27 authored Dec 11, 2024
1 parent 54b39a2 commit d59c5bf
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ export function useLaunchMultipleRunsWithTelemetry() {
jobNames.includes(undefined) ||
jobNames.includes(null)
) {
throw new Error('Invalid job names');
throw new Error(
'Error: Invalid job names. Each RunRequest must specify a job name to launch all runs',
);
}

const metadata: {[key: string]: string | string[] | null | undefined} = {
Expand Down

1 comment on commit d59c5bf

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-nryr7szx2-elementl.vercel.app

Built with commit d59c5bf.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.