-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Restrict CodeLocationSource hostnames (#27364)
## Summary & Motivation Try to resolve: - https://github.com/dagster-io/dagster/security/code-scanning/18 - https://github.com/dagster-io/dagster/security/code-scanning/19 Within `CodeLocationSource`, we currently check whether `github.com` or `gitlab.com` are included in the hostname at all. This only affects how we render the outbound link or button, but even so, we should be more restrictive about this. ## How I Tested These Changes `yarn jest CodeLocationSource`
- Loading branch information
Showing
2 changed files
with
16 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9c726c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-4m2o3cn7r-elementl.vercel.app
Built with commit d9c726c.
This pull request is being automatically deployed with vercel-action