-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] Move stepStats out of RunRootQuery (#26610)
## Summary & Motivation Move `stepStats` out of the root Run query, since it can be expensive. Instead, query for it at the `RunMetadataProvider`. This should allow the header, Gantt chart, and logs to load even while the step stats panel of the page continues to load. ## How I Tested These Changes View a very long-running run. Verify that the Run header, Gantt chart, and logs appear fairly quickly, and the right panel takes a bit longer to load. ## Changelog [ui] Improve performance of Run page for very long-running runs.
- Loading branch information
Showing
7 changed files
with
108 additions
and
75 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 1 addition & 18 deletions
19
...s/dagster-ui/packages/ui-core/src/runs/__tests__/types/RunActionButtonsTestQuery.types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
js_modules/dagster-ui/packages/ui-core/src/runs/types/RunFragments.types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
48 changes: 48 additions & 0 deletions
48
js_modules/dagster-ui/packages/ui-core/src/runs/types/RunMetadataProvider.types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
19 changes: 1 addition & 18 deletions
19
js_modules/dagster-ui/packages/ui-core/src/runs/types/RunRoot.types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
d9ddad4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-p6wt3dwg8-elementl.vercel.app
Built with commit d9ddad4.
This pull request is being automatically deployed with vercel-action