Skip to content

Commit

Permalink
Fix flaky test (#25965)
Browse files Browse the repository at this point in the history
## Summary & Motivation

Following some breadcrumbs from the error message that would sometimes
get spit out, it seems like this should be set to True in test
scenarios.

## How I Tested These Changes

Hard to prove a negative, but I was able to repro the issue locally
within 5 runs of the suite, and after this change 10 local runs
succeeded

## Changelog

NOCHANGELOG
  • Loading branch information
OwenKephart authored Nov 16, 2024
1 parent 96a05c4 commit dc06f80
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def get_grpc_workspace_request_context(filename: str, instance_ref: Optional[Ins
instance_ref=instance.get_ref(),
loadable_target_origin=get_loadable_target_origin(filename),
max_workers=4,
wait_on_exit=False,
wait_on_exit=True,
) as server_process:
target = GrpcServerTarget(
host="localhost",
Expand Down

0 comments on commit dc06f80

Please sign in to comment.