[1.9] Replace Auto-materialize references in the UI with Automation c…

…ondition (#25414) ## Summary & Motivation Just hunting down references to the deprecated terminology. Left the old global AMP page as-is, as this is a legacy concept and it might be more confusing to see it refered to using DA terminology. ## How I Tested These Changes ## Changelog NOCHANGELOG
dagster-io · Oct 25, 2024 · dcf496f · dcf496f
1 parent cfed1d9
commit dcf496f
Show file tree

Hide file tree

Showing 17 changed files with 27 additions and 63 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-components/src/components/Icon.tsx b/js_modules/dagster-ui/packages/ui-components/src/components/Icon.tsx
@@ -26,9 +26,9 @@ import asset_plot from '../icon-svgs/asset_plot.svg';
 import assignment from '../icon-svgs/assignment.svg';
 import assignment_turned_in from '../icon-svgs/assignment_turned_in.svg';
 import attach_file from '../icon-svgs/attach_file.svg';
-import auto_materialize_policy from '../icon-svgs/auto_materialize_policy.svg';
 import auto_observe from '../icon-svgs/auto_observe.svg';
 import automation from '../icon-svgs/automation.svg';
+import automation_condition from '../icon-svgs/automation_condition.svg';
 import backfill from '../icon-svgs/backfill.svg';
 import badge from '../icon-svgs/badge.svg';
 import bar_chart from '../icon-svgs/bar_chart.svg';
@@ -424,7 +424,7 @@ export const Icons = {
   assignment,
   assignment_turned_in,
   attach_file,
-  auto_materialize_policy,
+  automation_condition,
   auto_observe,
   automation,
   backfill,

diff --git a/...src/icon-svgs/auto_materialize_policy.svg → ...ts/src/icon-svgs/automation_condition.svg b/...src/icon-svgs/auto_materialize_policy.svg → ...ts/src/icon-svgs/automation_condition.svg
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeOverview.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeOverview.tsx
@@ -661,7 +661,7 @@ export const AssetNodeOverview = ({
           <LargeCollapsibleSection header="Definition" icon="info">
             {renderDefinitionSection()}
           </LargeCollapsibleSection>
-          <LargeCollapsibleSection header="Automation details" icon="auto_materialize_policy">
+          <LargeCollapsibleSection header="Automation details" icon="automation_condition">
             {renderAutomationDetailsSection()}
           </LargeCollapsibleSection>
           {cachedOrLiveAssetNode.isExecutable ? (

diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AutomaterializeDaemonStatusTag.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AutomaterializeDaemonStatusTag.tsx
@@ -10,7 +10,7 @@ export const AutomaterializeDaemonStatusTag = () => {
     <Tooltip
       content={
         paused
-          ? 'Auto-materializing is paused. New materializations will not be triggered by auto-materialization policies.'
+          ? 'Automation condition evaluation is paused. New materializations will not be triggered by automation conditions.'
           : ''
       }
       canShow={paused}

diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AutomaterializeTagWithEvaluation.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AutomaterializeTagWithEvaluation.tsx
@@ -23,7 +23,7 @@ export const AutomaterializeTagWithEvaluation = ({assetKeys, evaluationId}: Prop
       content={
         <div style={{width: '340px'}}>
           <Box padding={{vertical: 8, horizontal: 12}} border="bottom" style={{fontWeight: 600}}>
-            Auto-materialized
+            Automation condition
           </Box>
           <Box
             flex={{direction: 'column', gap: 12}}
@@ -65,7 +65,7 @@ export const AutomaterializeTagWithEvaluation = ({assetKeys, evaluationId}: Prop
       }
       interactionKind="hover"
     >
-      <Tag icon="auto_materialize_policy">Auto-materialized</Tag>
+      <Tag icon="automation_condition">Automation condition</Tag>
     </Popover>
   );
 };
diff --git a/...gster-ui/packages/ui-core/src/assets/auto-materialization/DeclarativeAutomationBanner.tsx b/...gster-ui/packages/ui-core/src/assets/auto-materialization/DeclarativeAutomationBanner.tsx
diff --git a/...-ui/packages/ui-core/src/assets/auto-materialization/GlobalAutomaterializationContent.tsx b/...-ui/packages/ui-core/src/assets/auto-materialization/GlobalAutomaterializationContent.tsx
@@ -12,7 +12,6 @@ import {useCallback, useMemo, useState} from 'react';
 import {ASSET_DAEMON_TICKS_QUERY} from './AssetDaemonTicksQuery';
 import {AutomaterializationTickDetailDialog} from './AutomaterializationTickDetailDialog';
 import {AutomaterializeRunHistoryTable} from './AutomaterializeRunHistoryTable';
-import {DeclarativeAutomationBanner} from './DeclarativeAutomationBanner';
 import {InstanceAutomaterializationEvaluationHistoryTable} from './InstanceAutomaterializationEvaluationHistoryTable';
 import {
   AssetDaemonTickFragment,
@@ -146,9 +145,6 @@ export const GlobalAutomaterializationContent = () => {
 
   return (
     <>
-      <Box padding={{vertical: 12, horizontal: 24}}>
-        <DeclarativeAutomationBanner />
-      </Box>
       <Table>
         <tbody>
           <tr>

diff --git a/js_modules/dagster-ui/packages/ui-core/src/automation/MergedAutomationRoot.tsx b/js_modules/dagster-ui/packages/ui-core/src/automation/MergedAutomationRoot.tsx
@@ -89,7 +89,7 @@ export const MergedAutomationRoot = () => {
   const automationTypeFilter = useStaticSetFilter({
     name: 'Automation type',
     allValues: ALL_AUTOMATION_VALUES,
-    icon: 'auto_materialize_policy',
+    icon: 'automation_condition',
     getStringValue: (value) => value.label,
     state: automationFilterState,
     renderLabel: ({value}) => <span>{value.label}</span>,

diff --git a/js_modules/dagster-ui/packages/ui-core/src/overview/groupRunsByAutomation.tsx b/js_modules/dagster-ui/packages/ui-core/src/overview/groupRunsByAutomation.tsx
@@ -39,7 +39,7 @@ const automationName = (automation: RunAutomation | null) => {
   const {type} = automation;
   switch (type) {
     case 'legacy-amp':
-      return 'Auto-materialized';
+      return 'Automation condition';
     case 'schedule':
     case 'sensor':
       return automation.name;

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/CreatedByTag.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/CreatedByTag.tsx
@@ -29,7 +29,7 @@ export const CreatedByTagCellWrapper = styled(Box)``;
 
 type TagType =
   | {
-      type: 'user' | 'schedule' | 'sensor' | 'auto-materialize' | 'auto-observe';
+      type: 'user' | 'schedule' | 'sensor' | 'automation-condition' | 'auto-observe';
       tag: RunTagsFragment;
     }
   | {type: 'manual'};
@@ -53,11 +53,11 @@ const pluckTagFromList = (tags: RunTagsFragment[]): TagType => {
     const {key} = tag;
     switch (key) {
       case DagsterTag.Automaterialize:
-        return {type: 'auto-materialize', tag};
+        return {type: 'automation-condition', tag};
       case DagsterTag.CreatedBy: {
         // Backwards compatibility
         if (tag.value === 'auto_materialize') {
-          return {type: 'auto-materialize', tag};
+          return {type: 'automation-condition', tag};
         } else {
           continue;
         }
@@ -105,8 +105,8 @@ export const CreatedByTag = ({repoAddress, tags, onAddTag}: Props) => {
           </Tag>
         );
       }
-      case 'auto-materialize':
-        return <Tag icon="auto_materialize_policy">Auto-materialize policy</Tag>;
+      case 'automation-condition':
+        return <Tag icon="automation_condition">Automation condition</Tag>;
       case 'auto-observe':
         return <Tag icon="auto_observe">Auto-observation</Tag>;
     }

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunTag.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunTag.tsx
@@ -5,6 +5,7 @@ import {Link} from 'react-router-dom';
 import {TagAction, TagActionsPopover} from '../ui/TagActions';
 
 export enum DagsterTag {
+  AutomationCondition = 'dagster/from_automation_condition',
   Automaterialize = 'dagster/auto_materialize',
   AutoObserve = 'dagster/auto_observe',
   Namespace = 'dagster/',

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/RunsFilterInput.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/RunsFilterInput.tsx
@@ -499,8 +499,8 @@ export const useRunsFilterInput = ({tokens, onChange, enabledFilters}: RunsFilte
       } else if (value.type === DagsterTag.User) {
         return <UserDisplay email={value.value!} isFilter />;
       } else if (value.type === DagsterTag.Automaterialize) {
-        icon = <Icon name="auto_materialize_policy" />;
-        labelValue = 'Auto-materialize policy';
+        icon = <Icon name="automation_condition" />;
+        labelValue = 'Automation condition';
       }
       return (
         <Box flex={{direction: 'row', gap: 4, alignItems: 'center'}}>
@@ -511,7 +511,7 @@ export const useRunsFilterInput = ({tokens, onChange, enabledFilters}: RunsFilte
     },
     getStringValue: (x) => {
       if (x.type === DagsterTag.Automaterialize) {
-        return 'Auto-materialize policy';
+        return 'Automation condition';
       }
       return x.value!;
     },

diff --git a/js_modules/dagster-ui/packages/ui-core/src/sensors/SensorPageAutomaterialize.tsx b/js_modules/dagster-ui/packages/ui-core/src/sensors/SensorPageAutomaterialize.tsx
@@ -13,7 +13,6 @@ import {useFeatureFlags} from '../app/Flags';
 import {useRefreshAtInterval} from '../app/QueryRefresh';
 import {AutomaterializationTickDetailDialog} from '../assets/auto-materialization/AutomaterializationTickDetailDialog';
 import {AutomaterializeRunHistoryTable} from '../assets/auto-materialization/AutomaterializeRunHistoryTable';
-import {DeclarativeAutomationBanner} from '../assets/auto-materialization/DeclarativeAutomationBanner';
 import {SensorAutomaterializationEvaluationHistoryTable} from '../assets/auto-materialization/SensorAutomaterializationEvaluationHistoryTable';
 import {AssetDaemonTickFragment} from '../assets/auto-materialization/types/AssetDaemonTicksQuery.types';
 import {InstigationTickStatus, RunsFilter} from '../graphql/types';
@@ -168,9 +167,6 @@ export const SensorPageAutomaterialize = (props: Props) => {
 
   return (
     <>
-      <Box padding={{vertical: 12, horizontal: 24}}>
-        <DeclarativeAutomationBanner />
-      </Box>
       <SensorInfo assetDaemonHealth={daemonStatus} padding={{vertical: 16, horizontal: 24}} />
       <Box padding={{vertical: 12, horizontal: 24}} border="bottom">
         <Subtitle2>Evaluation timeline</Subtitle2>

diff --git a/js_modules/dagster-ui/packages/ui-core/src/sensors/SensorRoot.tsx b/js_modules/dagster-ui/packages/ui-core/src/sensors/SensorRoot.tsx
@@ -17,7 +17,6 @@ import {PYTHON_ERROR_FRAGMENT} from '../app/PythonErrorFragment';
 import {PythonErrorInfo} from '../app/PythonErrorInfo';
 import {FIFTEEN_SECONDS, useMergedRefresh, useQueryRefreshAtInterval} from '../app/QueryRefresh';
 import {useTrackPageView} from '../app/analytics';
-import {DeclarativeAutomationBanner} from '../assets/auto-materialization/DeclarativeAutomationBanner';
 import {AUTOMATION_ASSET_SELECTION_FRAGMENT} from '../automation/AutomationAssetSelectionFragment';
 import {InstigationTickStatus, SensorType} from '../graphql/types';
 import {useDocumentTitle} from '../hooks/useDocumentTitle';
@@ -156,11 +155,6 @@ export const SensorRoot = ({repoAddress}: {repoAddress: RepoAddress}) => {
         sensorDaemonStatus={sensorDaemonStatus}
         padding={{vertical: 16, horizontal: 24}}
       />
-      {isAutomationSensor && (
-        <Box padding={{vertical: 12, horizontal: 24}}>
-          <DeclarativeAutomationBanner />
-        </Box>
-      )}
       <TickHistoryTimeline
         tickResultType={tickResultType}
         repoAddress={repoAddress}

diff --git a/js_modules/dagster-ui/packages/ui-core/src/workspace/VirtualizedSensorRow.tsx b/js_modules/dagster-ui/packages/ui-core/src/workspace/VirtualizedSensorRow.tsx
@@ -284,14 +284,15 @@ export const SENSOR_TYPE_META: Record<
   },
   [SensorType.AUTO_MATERIALIZE]: {
     name: 'Automation condition sensor',
-    icon: 'auto_materialize_policy',
+    icon: 'automation_condition',
     description:
-      'Auto-materialize sensors trigger runs based on auto-materialize policies defined on assets.',
+      'Automation condition sensors trigger runs based on conditions defined on assets or checks.',
   },
   [SensorType.AUTOMATION]: {
     name: 'Automation condition sensor',
-    icon: 'auto_materialize_policy',
-    description: 'Automation sensors trigger runs based on conditions defined on assets.',
+    icon: 'automation_condition',
+    description:
+      'Automation condition sensors trigger runs based on conditions defined on assets or checks.',
   },
   [SensorType.FRESHNESS_POLICY]: {
     name: 'Freshness policy sensor',

diff --git a/python_modules/dagster/dagster/_daemon/asset_daemon.py b/python_modules/dagster/dagster/_daemon/asset_daemon.py
@@ -281,7 +281,7 @@ def __exit__(
             ):
                 try:
                     raise Exception(
-                        "Unable to reach the code server. Auto-materialization will resume once the code server is available."
+                        "Unable to reach the code server. Automation condition evaluation will resume once the code server is available."
                     ) from exception_value
                 except:
                     error_data = DaemonErrorCapture.on_exception(sys.exc_info())
@@ -853,7 +853,7 @@ def _process_auto_materialize_tick_generator(
             error_info = DaemonErrorCapture.on_exception(
                 exc_info=sys.exc_info(),
                 logger=self._logger,
-                log_message="Auto-materialize daemon caught an error",
+                log_message="Automation condition daemon caught an error",
             )
 
         yield error_info

diff --git a/...ons_tests/declarative_automation_tests/daemon_tests/test_asset_daemon_failure_recovery.py b/...ons_tests/declarative_automation_tests/daemon_tests/test_asset_daemon_failure_recovery.py
@@ -269,8 +269,9 @@ def test_error_loop_after_cursor_written(daemon_not_paused_instance, crash_locat
         assert ticks[0].tick_data.failure_count == 0
 
         assert "WHERE IS THE CODE" in str(ticks[0].tick_data.error)
-        assert "Auto-materialization will resume once the code server is available" in str(
-            ticks[0].tick_data.error
+        assert (
+            "Automation condition evaluation will resume once the code server is available"
+            in str(ticks[0].tick_data.error)
         )
 
         # Run requests are still on the tick since they were stored there before the