Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ui] backfill preview modal - if an asset won't launch any partitions…
… show a message instead of a spinner (#26080) ## Summary & Motivation If you select a group of assets to backfill and select a range such that a subset of the assets have no partitions in that range, the Backfill Preview modal shows spinners for those assets For example - for the following asset graph <img width="743" alt="Screenshot 2024-11-21 at 11 46 09 AM" src="https://github.com/user-attachments/assets/08b3c5c5-9c32-417d-b2ea-4daaf716417d"> If you select only the latest hour to materialize, the daily asset will have no valid partitions to materialize (materializing today's asset isn't available until tomorrow) If you then click the "Backfill Preview" button, we show an infinite spinner for the daily asset ![image (19)](https://github.com/user-attachments/assets/ef08731b-8b8e-4f28-a53a-3eca5ad2b648) This PR adds a message when we know an asset wont have any partitions targeted by the backfill <img width="1113" alt="Screenshot 2024-11-21 at 11 41 39 AM" src="https://github.com/user-attachments/assets/6cbcd0d3-1444-4235-be7f-f229e9e41edc"> ## How I Tested These Changes ## Changelog [ui] Fixed a bug in the Backfill Preview where a loading spinner would spin forever if an asset had no valid partitions targeted by the backfill
- Loading branch information
ef2817d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-77k5cfo6a-elementl.vercel.app
Built with commit ef2817d.
This pull request is being automatically deployed with vercel-action