Stop reduce anti-pattern contagion 2 (#22462)

## Summary & Motivation

Missed a few spots in #22454

## How I Tested These Changes

load the app and visit various pages without crashing + ts / jest

js_modules/dagster-ui/packages/ui-components/src/components/TokenizingField.tsx

@@ -188,11 +188,12 @@ export const TokenizingField = ({
       // Suggest providers (eg: `pipeline:`) so users can discover the search space
 
       suggestionsArr = filteredSuggestionProviders
-        .reduce(
-          (accum: Suggestion[], s) =>
-            s.token ? [...accum, {text: `${s.token}:`, final: false}] : accum,
-          [],
-        )
+        .reduce((accum: Suggestion[], s) => {
+          if (s.token) {
+            accum.push({text: `${s.token}:`, final: false});
+          }
+          return accum;
+        }, [])
         .filter((s) => matchesTypedText(lastPart, s));
 
       // Suggest value completions so users can type "airline_" without the "pipeline"

js_modules/dagster-ui/packages/ui-core/src/assets/AssetLineageElements.tsx

@@ -42,16 +42,15 @@ const AssetLineageInfoElement = ({
           <Box flex={{display: 'inline-flex', alignItems: 'center'}}>
             {lineage_info.assetKey.path
               .map((p, i) => <span key={i}>{p}</span>)
-              .reduce(
-                (accum, curr, ii) => [
-                  ...accum,
-                  ii > 0 ? (
-                    <React.Fragment key={`${ii}-space`}>&nbsp;{'>'}&nbsp;</React.Fragment>
-                  ) : null,
-                  curr,
-                ],
-                [] as React.ReactNode[],
-              )}
+              .reduce((accum, curr, ii) => {
+                if (ii > 0) {
+                  accum.push(
+                    <React.Fragment key={`${ii}-space`}>&nbsp;{'>'}&nbsp;</React.Fragment>,
+                  );
+                }
+                accum.push(curr);
+                return accum;
+              }, [] as React.ReactNode[])}
           </Box>
         </Link>
       </Tooltip>

js_modules/dagster-ui/packages/ui-core/src/assets/AssetLink.tsx

@@ -14,7 +14,14 @@ export const AssetLink = (props: {
   const linkUrl = url ? url : assetDetailsPathForKey({path});
   const assetPath =
     path
-      .reduce((accum, elem, ii) => [...accum, ii > 0 ? ' / ' : '', elem], [] as string[])
+      .reduce((accum, elem, ii) => {
+        if (ii > 0) {
+          accum.push(' / ');
+        }
+        accum.push(elem);
+        return accum;
+      }, [] as string[])
+
       .join('') + (isGroup ? '/' : '');
 
   return (

js_modules/dagster-ui/packages/ui-core/src/runs/Run.tsx

@@ -223,7 +223,8 @@ const RunWithData = ({
     ? logsFilter.logQuery
         .filter((v) => v.token && v.token === 'query')
         .reduce((accum, v) => {
-          return [...accum, ...filterByQuery(runtimeGraph, v.value).all.map((n) => n.name)];
+          accum.push(...filterByQuery(runtimeGraph, v.value).all.map((n) => n.name));
+          return accum;
         }, [] as string[])
     : [];
 

js_modules/dagster-ui/packages/ui-core/src/search/useGlobalSearch.tsx

@@ -80,8 +80,7 @@ const primaryDataToSearchResults = (input: {data?: SearchPrimaryQuery}) => {
 
     const repoLocation = locationEntry.locationOrLoadError;
     const repos = repoLocation.repositories;
-    return [
-      ...accum,
+    accum.push(
       ...repos.reduce((inner, repo) => {
         const {
           name: repoName,
@@ -175,7 +174,8 @@ const primaryDataToSearchResults = (input: {data?: SearchPrimaryQuery}) => {
           ...allResources,
         ];
       }, [] as SearchResult[]),
-    ];
+    );
+    return accum;
   }, [] as SearchResult[]);
 
   return allEntries;

js_modules/dagster-ui/packages/ui-core/src/workspace/WorkspaceContext.tsx

@@ -276,7 +276,8 @@ export const WorkspaceProvider = ({children}: {children: React.ReactNode}) => {
         }
         const repositoryLocation = locationEntry.locationOrLoadError;
         const reposForLocation = repoLocationToRepos(repositoryLocation);
-        return [...accum, ...reposForLocation];
+        accum.push(...reposForLocation);
+        return accum;
       }, [] as DagsterRepoOption[]),
 
       // Sort by repo location, then by repo