Skip to content

Commit

Permalink
Don't propagate click events from popover + remove unnecessary overfl…
Browse files Browse the repository at this point in the history
…ow hidden (#23443)

## Summary & Motivation

1. Don't propagate click events from the popover of ProductTour since by
default blueprint's `Popover` seems to bubble them up to the element its
wrapping (super weird!).
2. Remove overflow: hidden from the AssetPageHeader because this wraps a
button that uses outerglow on hover and the overflow hidden ends up
hiding the outerglow making it look weird.
  • Loading branch information
salazarm authored Aug 6, 2024
1 parent 4ebdb25 commit f3ce9a8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,11 @@ export const ProductTour = ({
}}
minimal={false}
content={
<>
<div
onClick={(ev) => {
ev.stopPropagation();
}}
>
<div />
<ProductTourContainer flex={{direction: 'column', gap: 4}} padding={16} style={{width}}>
<Box flex={{direction: 'column', gap: 8}}>
Expand All @@ -95,7 +99,7 @@ export const ProductTour = ({
{actionsJsx}
</ProductTourContainer>
<div />
</>
</div>
}
>
{children}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,7 @@ export const AssetPageHeader = ({
return (
<PageHeader
title={
<Box
flex={{alignItems: 'center', gap: 4}}
style={{maxWidth: '600px', overflow: 'hidden', marginBottom: 4}}
>
<Box flex={{alignItems: 'center', gap: 4}} style={{maxWidth: '600px', marginBottom: 4}}>
<Title>
<BreadcrumbsWithSlashes
items={breadcrumbs}
Expand Down

2 comments on commit f3ce9a8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-az561nazk-elementl.vercel.app

Built with commit f3ce9a8.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-qe3hundj3-elementl.vercel.app

Built with commit f3ce9a8.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.