-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't propagate click events from popover + remove unnecessary overfl…
…ow hidden (#23443) ## Summary & Motivation 1. Don't propagate click events from the popover of ProductTour since by default blueprint's `Popover` seems to bubble them up to the element its wrapping (super weird!). 2. Remove overflow: hidden from the AssetPageHeader because this wraps a button that uses outerglow on hover and the overflow hidden ends up hiding the outerglow making it look weird.
- Loading branch information
Showing
2 changed files
with
7 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f3ce9a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-az561nazk-elementl.vercel.app
Built with commit f3ce9a8.
This pull request is being automatically deployed with vercel-action
f3ce9a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-storybook ready!
✅ Preview
https://dagit-storybook-qe3hundj3-elementl.vercel.app
Built with commit f3ce9a8.
This pull request is being automatically deployed with vercel-action