-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[dagster-aws] add
PipesEMRServerlessClient
(#24318)
## Summary & Motivation resolve [DS-443](https://linear.app/dagster-labs/issue/DS-443/implement-pipes-emr-serverless) Implemented message reading for CloudWatch logging configuration (using `CloudWatchMessageReader`). Mapping Spark driver stdout/stderr to Dagster's stdout/stderr. S3-backed logs are currently blocked by #24098 ## How I Tested These Changes 1. Manually tested with real AWS infra (personal account) 2. Added a very simple test which checks that context env vars are set correctly. This is as far as we can get with `moto` since they don't have `start_job_run` implemented. I'm planning to add integration tests in CI with real AWS infra. ## Changelog Insert changelog entry or "NOCHANGELOG" here. - [x] `NEW` _([dagster-aws] added `PipesEMRServerlessClient`, but it's untested yet so please don't include into release notes until we have tests)_ - [ ] `BUGFIX` _(fixed a bug)_ - [ ] `DOCS` _(added or updated documentation)_
- Loading branch information
1 parent
5a82882
commit f4cff85
Showing
11 changed files
with
404 additions
and
17 deletions.
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
python_modules/libraries/dagster-aws/dagster_aws/pipes/clients/__init__.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
from dagster_aws.pipes.clients.ecs import PipesECSClient | ||
from dagster_aws.pipes.clients.emr_serverless import PipesEMRServerlessClient | ||
from dagster_aws.pipes.clients.glue import PipesGlueClient | ||
from dagster_aws.pipes.clients.lambda_ import PipesLambdaClient | ||
|
||
__all__ = ["PipesGlueClient", "PipesLambdaClient", "PipesECSClient"] | ||
__all__ = ["PipesGlueClient", "PipesLambdaClient", "PipesECSClient", "PipesEMRServerlessClient"] |
Oops, something went wrong.
f4cff85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagster-docs ready!
✅ Preview
https://dagster-docs-hzfih4fab-elementl.vercel.app
https://master.dagster.dagster-docs.io
Built with commit f4cff85.
This pull request is being automatically deployed with vercel-action