allow selecting all kinds

dagster-io · Sep 6, 2024 · f803e74 · f803e74
1 parent 44637d5
commit f803e74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/useAssetCatalogFiltering.oss.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/useAssetCatalogFiltering.oss.tsx
@@ -77,7 +77,7 @@ export function useAssetCatalogFiltering<
   const allKinds = useAssetKindsForAssets(assets);
   const kindFilter = useKindFilter({
     allAssetKinds: allKinds,
-    kinds: filters.selectAllFilters.includes('kinds') ? [] : filters.kinds,
+    kinds: filters.selectAllFilters.includes('kinds') ? allKinds : filters.kinds,
     setKinds,
   });
 
@@ -152,6 +152,7 @@ export function useAssetCatalogFiltering<
     [
       ['owners', filters.owners, allAssetOwners] as const,
       ['tags', filters.tags, tags] as const,
+      ['kinds', filters.kinds, allKinds] as const,
       ['groups', filters.groups, allAssetGroupOptions] as const,
       ['changedInBranch', filters.changedInBranch, Object.values(ChangeReason)] as const,
       ['codeLocations', filters.codeLocations, allRepos] as const,

diff --git a/js_modules/dagster-ui/packages/ui-core/src/ui/Filters/useKindFilter.tsx b/js_modules/dagster-ui/packages/ui-core/src/ui/Filters/useKindFilter.tsx
@@ -31,7 +31,7 @@ export const useKindFilter = ({
     onStateChanged: (values) => {
       setKinds?.(Array.from(values));
     },
-    canSelectAll: false,
+    canSelectAll: true,
   });
 };