Skip to content

Commit

Permalink
Add table name filter type (#25346)
Browse files Browse the repository at this point in the history
Corresponding internal PR:
dagster-io/internal#12126
  • Loading branch information
clairelin135 authored Nov 5, 2024
1 parent 7dcdc25 commit f84b5b8
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ const iconForType = (type: SearchResultType | AssetFilterSearchResultType): Icon
return 'view_column';
case AssetFilterSearchResultType.ColumnTag:
return 'tag';
case AssetFilterSearchResultType.TableName:
return 'database';
default:
assertUnreachable(type);
}
Expand All @@ -80,6 +82,8 @@ const assetFilterPrefixString = (type: AssetFilterSearchResultType): string => {
return 'Column';
case AssetFilterSearchResultType.ColumnTag:
return 'Column tag';
case AssetFilterSearchResultType.TableName:
return 'Table name';
default:
assertUnreachable(type);
}
Expand Down
4 changes: 3 additions & 1 deletion js_modules/dagster-ui/packages/ui-core/src/search/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export enum AssetFilterSearchResultType {
AssetGroup = 'AssetFilterSearchResultType.AssetGroup',
Column = 'AssetFilterSearchResultType.Column',
ColumnTag = 'AssetFilterSearchResultType.ColumnTag',
TableName = 'AssetFilterSearchResultType.TableName',
}

export function isAssetFilterSearchResultType(
Expand All @@ -47,7 +48,8 @@ export function isAssetFilterSearchResultType(
type === AssetFilterSearchResultType.Owner ||
type === AssetFilterSearchResultType.Tag ||
type === AssetFilterSearchResultType.Column ||
type === AssetFilterSearchResultType.ColumnTag
type === AssetFilterSearchResultType.ColumnTag ||
type === AssetFilterSearchResultType.TableName
);
}

Expand Down

1 comment on commit f84b5b8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-a92chfgtk-elementl.vercel.app

Built with commit f84b5b8.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.