Skip to content

Commit

Permalink
[ui] Add padding to page headers for scenarios when they wrap (#25752)
Browse files Browse the repository at this point in the history
## Summary & Motivation

This was noticed during the runs feed testing but wasn't specific to the
runs feed. In general, if you make the page narrow enough that the page
header wraps, there is no padding and the top text touches the navbar.
We also didn't mandate padding to the left of the right-side actions,
and this PR adds a gap there as well.

## How I Tested These Changes

Tested manually on a variety of pages + screen sizes

Co-authored-by: bengotow <[email protected]>
  • Loading branch information
bengotow and bengotow authored Nov 7, 2024
1 parent 00990b2 commit f8afd1a
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ export const PageHeader = (props: Props) => {
>
{title && (
<Box
padding={{vertical: 8}}
style={{minHeight: 52, alignContent: 'center'}}
flex={{direction: 'row', justifyContent: 'space-between', alignItems: 'center'}}
flex={{direction: 'row', justifyContent: 'space-between', alignItems: 'center', gap: 8}}
>
<Box flex={{direction: 'row', alignItems: 'center', gap: 12, wrap: 'wrap'}}>
{title}
Expand Down

1 comment on commit f8afd1a

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-cqwgmllkj-elementl.vercel.app

Built with commit f8afd1a.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.