Skip to content

Commit

Permalink
pin pydantic < 2.9.0 (#24258)
Browse files Browse the repository at this point in the history
## Summary & Motivation

pydantic 2.9.0 (released 2024-09-05) introduces some breaking changes
causing

| `TableMetadataSet` is not fully defined; you should define
`TableColumn`, then call `TableMetadataSet.model_rebuild()`.

pinning to <2.9.0 should fix this

## How I Tested These Changes

existing tests

Co-authored-by: Neil Fulwiler <[email protected]>
(cherry picked from commit 0875c0b)
  • Loading branch information
neilfulwiler authored and jmsanders committed Sep 5, 2024
1 parent bbbaff9 commit f94fa1c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions examples/temp_pins.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@
# temporarily introduce pins for these tests until the next version of
# Dagster is published to PyPI.
responses==0.23.1
pydantic<2.9.0
2 changes: 1 addition & 1 deletion python_modules/dagster/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def get_version() -> str:
"universal_pathlib; python_version<'3.12'",
"universal_pathlib>=0.2.0; python_version>='3.12'",
# https://github.com/pydantic/pydantic/issues/5821
"pydantic>1.10.0,!= 1.10.7,<3",
"pydantic>1.10.0,!= 1.10.7,<2.9.0",
"rich",
"filelock",
f"dagster-pipes{pin}",
Expand Down
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-datahub/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def get_version() -> str:
f"dagster{pin}",
"packaging",
"requests",
"pydantic>=1.10.0,<3.0.0",
"pydantic>=1.10.0,<2.9.0",
],
extras_require={},
zip_safe=False,
Expand Down

0 comments on commit f94fa1c

Please sign in to comment.