Skip to content

Commit

Permalink
pr comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jamiedemaria committed Aug 28, 2024
1 parent 9593f31 commit fe13e09
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/docs-beta/docs/guides/external-systems/apis.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ This example fetches the sunrise time for a given location from a REST API. Begi

## Step 2: Use the resource in an asset

To use the resource written in Step 1, you can provide it as a parameter to an asset:
To use the resource written in Step 1, you can provide it as a parameter to an asset after including it in the Definitions object:

<CodeExample filePath="guides/external-systems/apis/use_minimal_resource_in_asset.py" language="python" title="Use the SunResource in an asset" />

Expand All @@ -55,7 +55,7 @@ When you materialize `sfo_sunrise`, Dagster will provide a `SunResource` initial


## Step 4: Source configuration values from environment variables
Resources can also be configured with environment variables. You can use Dagster's built-in `EnvVar` class to source configuration values from environment variables at materialization time.
Resources can also be configured with environment variables. You can use Dagster's built-in `EnvVar` class to source configuration values from environment variables at materialization time.
In this example, there is a new `home_sunrise` asset. Rather than hardcoding the location of your home, you can set it in environment variables, and configure the `SunResource` by reading those values:

Check failure on line 60 in docs/docs-beta/docs/guides/external-systems/apis.md

View workflow job for this annotation

GitHub Actions / runner / vale

[vale] reported by reviewdog 🐶 [Dagster.spelling] Is 'hardcoding' spelled correctly? Raw Output: {"message": "[Dagster.spelling] Is 'hardcoding' spelled correctly?", "location": {"path": "docs/docs-beta/docs/guides/external-systems/apis.md", "range": {"start": {"line": 60, "column": 67}}}, "severity": "ERROR"}

Check failure on line 60 in docs/docs-beta/docs/guides/external-systems/apis.md

View workflow job for this annotation

GitHub Actions / runner / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'hardcoding'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'hardcoding'?", "location": {"path": "docs/docs-beta/docs/guides/external-systems/apis.md", "range": {"start": {"line": 60, "column": 67}}}, "severity": "ERROR"}
Expand Down

0 comments on commit fe13e09

Please sign in to comment.