-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Accept KeyboardInterruptError in multiprocess executor termination lo…
…gic (#23408) Summary: The dagster signal handler raises interrupts as DagsterExecutionInterruptedError, but sometimes ops can run code that installs its own signal handler, causing the interrupt to be raised as a KeyboardInterrupt (for example, the snowflake python connector does this: https://github.com/snowflakedb/snowflake-connector-python/blob/main/src/snowflake/connector/cursor.py#L663-L684). Handle both in the logic that decides if a run terminated cleanly or not. Resolves #23406. Test Plan: BK ## Summary & Motivation ## How I Tested These Changes
- Loading branch information
Showing
2 changed files
with
24 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters