[ui] Sensor history: Fix tick ID variable

dagster-io · Aug 21, 2024 · ff263ac · ff263ac
1 parent 6d78319
commit ff263ac
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/instigation/TickDetailsDialog.tsx b/js_modules/dagster-ui/packages/ui-core/src/instigation/TickDetailsDialog.tsx
@@ -61,7 +61,7 @@ export const TickDetailsDialog = ({tickId, isOpen, instigationSelector, onClose}
 };
 
 interface InnerProps {
-  tickId: number | undefined;
+  tickId: string | undefined;
   instigationSelector: InstigationSelector;
 }
 

diff --git a/js_modules/dagster-ui/packages/ui-core/src/instigation/TickHistory.tsx b/js_modules/dagster-ui/packages/ui-core/src/instigation/TickHistory.tsx
@@ -308,9 +308,9 @@ export const TickHistoryTimeline = ({
   afterTimestamp?: number;
   statuses?: InstigationTickStatus[];
 }) => {
-  const [selectedTickId, setSelectedTickId] = useQueryPersistedState<number | undefined>({
+  const [selectedTickId, setSelectedTickId] = useQueryPersistedState<string | undefined>({
     encode: (tickId) => ({tickId}),
-    decode: (qs) => (qs['tickId'] ? Number(qs['tickId']) : undefined),
+    decode: (qs) => qs['tickId'] ?? undefined,
   });
 
   const [pollingPaused, pausePolling] = React.useState<boolean>(false);
@@ -364,7 +364,7 @@ export const TickHistoryTimeline = ({
   const {ticks = []} = data.instigationStateOrError;
 
   const onTickClick = (tick?: InstigationTick) => {
-    setSelectedTickId(tick ? Number(tick.tickId) : undefined);
+    setSelectedTickId(tick ? tick.tickId : undefined);
   };
 
   const onTickHover = (tick?: InstigationTick) => {
@@ -376,6 +376,7 @@ export const TickHistoryTimeline = ({
       pausePolling(true);
     }
   };
+
   return (
     <>
       <TickDetailsDialog
@@ -512,7 +513,7 @@ function TickRow({
           ) : null}
           <TickDetailsDialog
             isOpen={showResults}
-            tickId={Number(tick.tickId)}
+            tickId={tick.tickId}
             instigationSelector={instigationSelector}
             onClose={() => {
               setShowResults(false);

diff --git a/js_modules/dagster-ui/packages/ui-core/src/runs/TickTagForRun.tsx b/js_modules/dagster-ui/packages/ui-core/src/runs/TickTagForRun.tsx
@@ -32,7 +32,7 @@ export const TickTagForRun = ({instigationSelector, instigationType, tickId}: Pr
         isOpen={isOpen}
         onClose={() => setIsOpen(false)}
         instigationSelector={instigationSelector}
-        tickId={Number(tickId)}
+        tickId={tickId}
       />
     </>
   );