Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets web page memory leak #19726

Closed
EtienneT opened this issue Feb 10, 2024 · 2 comments · Fixed by #19796
Closed

Assets web page memory leak #19726

EtienneT opened this issue Feb 10, 2024 · 2 comments · Fixed by #19796
Assignees
Labels
type: bug Something isn't working type: UI/UX usability UI/UX Usability Issue

Comments

@EtienneT
Copy link

Dagster version

1.6.4

What's the issue?

Keep the /assets page in chrome opened for a while. Open dev tools and you will see the memory steadily increasing. After a while, the tab in chrome crash with an out of memory exception. This can take several hours.

What did you expect to happen?

No response

How to reproduce?

No response

Deployment type

Local

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@EtienneT EtienneT added the type: bug Something isn't working label Feb 10, 2024
@garethbrickman garethbrickman added the type: UI/UX usability UI/UX Usability Issue label Feb 13, 2024
@cmpadden
Copy link
Contributor

cmpadden commented Feb 14, 2024

Thanks for bringing this to our attention, @EtienneT -- I've confirmed that I experience the memory leak as well.

When using the Task Manager in Chrome, you can clearly see the number rise.

image

And using the Memory profiler in the developer tools, we can compare the object allocation between two heap snapshots and see in more detail where things are being allocated.

image

We'll dig into this further - thanks.

Edit: I also confirmed that it only appears to grow when the tab is focused, and not in the background.

@salazarm salazarm self-assigned this Feb 14, 2024
@salazarm salazarm linked a pull request Feb 14, 2024 that will close this issue
@salazarm
Copy link
Contributor

Thanks for the report, the fix will go out in our release this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: UI/UX usability UI/UX Usability Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants