Fix issue causing memory to explode on assets page #19796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prha
approved these changes
Feb 14, 2024
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b0022ad. |
jmsanders
pushed a commit
that referenced
this pull request
Feb 14, 2024
## Summary & Motivation This array is used as a dependency to setup a bunch of listeners. Because we're using `.map` we end up creating a new array on every render which causes us to unregister and register a new set of listeners endlessly. If your computer can keep up with the memory swapping then everything seems fine but if it can't your tab quickly grows unbounded. ## How I Tested These Changes Use the task manager and saw that the "Assets tab" is no longer using 50%+ CPU and that the memory usage isn't changing wildly. <img width="792" alt="Screenshot 2024-02-14 at 1 49 45 PM" src="https://github.com/dagster-io/dagster/assets/2286579/ef39d3a7-3768-408b-bccc-fa28d2b307ff"> (cherry picked from commit b2c9271)
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation This array is used as a dependency to setup a bunch of listeners. Because we're using `.map` we end up creating a new array on every render which causes us to unregister and register a new set of listeners endlessly. If your computer can keep up with the memory swapping then everything seems fine but if it can't your tab quickly grows unbounded. ## How I Tested These Changes Use the task manager and saw that the "Assets tab" is no longer using 50%+ CPU and that the memory usage isn't changing wildly. <img width="792" alt="Screenshot 2024-02-14 at 1 49 45 PM" src="https://github.com/dagster-io/dagster/assets/2286579/ef39d3a7-3768-408b-bccc-fa28d2b307ff">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This array is used as a dependency to setup a bunch of listeners. Because we're using
.mapwe end up creating a new array on every render which causes us to unregister and register a new set of listeners endlessly. If your computer can keep up with the memory swapping then everything seems fine but if it can't your tab quickly grows unbounded.How I Tested These Changes
Use the task manager and saw that the "Assets tab" is no longer using 50%+ CPU and that the memory usage isn't changing wildly.