Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.2 - ImportError: cannot import name 'runtime_version' from 'google.protobuf' #23854

Closed
rossserven opened this issue Aug 23, 2024 · 7 comments
Labels
integration: dbt Related to dagster-dbt type: bug Something isn't working

Comments

@rossserven
Copy link

Dagster version

1.8.2

What's the issue?

The 'Prepare DBT project for deployment' Github Action step is failing with

File "/home/runner/.local/lib/python3.8/site-packages/grpc_health/v1/health_pb2.py", line 9, in <module> from google.protobuf import runtime_version as _runtime_version ImportError: cannot import name 'runtime_version' from 'google.protobuf' (/home/runner/.local/lib/python3.8/site-packages/google/protobuf/__init__.py) Error: Process completed with exit code 1.

I am not seeing the same error under 1.8.1
install_requires=[ "dagster<1.8.2", "dagster-cloud<1.8.2", "dagster-dbt<1.8.2", ... ],

What did you expect to happen?

No response

How to reproduce?

No response

Deployment type

Dagster Cloud

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@rossserven rossserven added the type: bug Something isn't working label Aug 23, 2024
@rossserven rossserven changed the title ImportError: cannot import name 'runtime_version' from 'google.protobuf' 1.8.2 - ImportError: cannot import name 'runtime_version' from 'google.protobuf' Aug 23, 2024
@garethbrickman garethbrickman added the integration: dbt Related to dagster-dbt label Aug 26, 2024
@gibsondan
Copy link
Member

Hi @rossserven - thanks for reporting this, we're fixing the action in dagster-io/dagster-cloud-action#195. You can apply that same change to your github repo and it should work (specifically, replacing pip install pip --upgrade with python -m pip install pip --upgrade in the two action YAML files).

@garethbrickman garethbrickman linked a pull request Aug 28, 2024 that will close this issue
@gibsondan
Copy link
Member

This is now fixed for new users going through the flow. If the github action has already been scaffolded in a github repo, applying the change above will fix it.

@gibsondan gibsondan reopened this Aug 30, 2024
@gibsondan
Copy link
Member

Hold that thought actually - we temporarily rolled back the fix, but it should be live soon. The above workaround should still work in the meantime.

@cyclonstep
Copy link

@gibsondan hello, I also found this problem lately and it really locks me for getting the newest version. Is this actually still in the broken state now or can I just re-scaffold it?

@gibsondan
Copy link
Member

This is fixed now if you re-scaffold, sorry for not updating this task. Or you can apply that change above to the action yaml if you have already scaffolded.

@cyclonstep
Copy link

cyclonstep commented Sep 13, 2024

@gibsondan thank you very much 👍
If I don't want to re-scaffold the project, do I just need to update the action yaml like this?
https://github.com/dagster-io/dagster-cloud-action/pull/195/files#diff-050229b268df6169d016a0f0c43b5f7ab7280b21541d86bb3412a08a8c579ae4

@gibsondan
Copy link
Member

That’s all you should need to do to make it work, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: dbt Related to dagster-dbt type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants