Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grpcio pin in dagster-dbt #23990

Closed

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Aug 27, 2024

Summary & Motivation

This PR pins grpcio<1.65.0 in dagster-dbt to fix issue #23854. Also pins grpcio-health-checking as a safety net in the future.

Without this change, grpcio==1.66.0 and grpcio-health-checking==1.62.3 in Dagster 1.8.2.

How I Tested These Changes

make dev_install

Changelog [New | Bug | Docs]

NOCHANGELOG

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maximearmstrong and the rest of your teammates on Graphite Graphite

@maximearmstrong maximearmstrong self-assigned this Aug 27, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review August 27, 2024 23:27
@maximearmstrong
Copy link
Contributor Author

Fixed in dagster-cloud-action by changing how pip is updated in our CI/CD files - pip was outdated and not updated properly, so it couldn't resolve the grpcio version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.8.2 - ImportError: cannot import name 'runtime_version' from 'google.protobuf'
1 participant