[eslint] Bump prettier, eslint config version #16652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
hellendag
commented
Sep 20, 2023
Comment on lines
+118
to
+121
| const nextFireDelay = React.useMemo( | ||
| () => (nextFireMs ? nextFireMs - Date.now() : -1), | ||
| [nextFireMs], | ||
| ); |
There was a problem hiding this comment.
Note the Prettier changes with v3.
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit a575230. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit a575230. |
hellendag
force-pushed
the
dish/bump-eslint-config
branch
from
5a26d64 to
a575230
Compare
salazarm
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Update dependencies in eslint-config and elsewhere in
dagster-uiJS packages. I'll publish eslint-config once this is, and use it in our use cases in OSS and Cloud.The
ui-componentspackage uses the published eslint-config package, so that will get updated in a followup.How I Tested These Changes
TS, lint.