[Asset graph sidebar] Minor improvements #16729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit fceb744. |
bengotow
approved these changes
Sep 26, 2023
| @@ -84,7 +84,7 @@ export const AssetGraphExplorerSidebar = React.memo( | |||
| if (!assetGraphData.nodes[id]) { | |||
| try { | |||
| const path = JSON.parse(id); | |||
| const nextOpsQuery = `${explorerPath.opsQuery} \"${tokenForAssetKey({path})}\"`; | |||
| const nextOpsQuery = `\"${tokenForAssetKey({path})}\"`; | |||
clairelin135
pushed a commit
that referenced
this pull request
Sep 26, 2023
## Summary & Motivation - [x] Set the cursor to `Pointer` on hover on the sidebar items - [x] [Nit] The active state background color for sidebar items should be blue.50 - [x] [Nit] Change the arrow icon back to the … icon because it feels a little odd to have two arrow icons [Nit] Remove the gray line on the left side of the top level here - [x] [Usability] Replace the query instead of appending it. - [x] Change “repository” to “Code location” in the filter dropdown - [x] Fix buggy search by using Suggest instead ## How I Tested These Changes locally in OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Pointeron hover on the sidebar items[Nit] Remove the gray line on the left side of the top level here
How I Tested These Changes
locally in OSS