Refactor asset key resolution in @asset and @graph_asset #16752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
schrockn
force-pushed
the
refactor-resolve-key-resolution
branch
from
1e1bc09 to
0e68ad0
Compare
johannkm
approved these changes
Sep 25, 2023
schrockn
force-pushed
the
graph-asset
branch
from
176ed79 to
091d5f5
Compare
schrockn
force-pushed
the
refactor-resolve-key-resolution
branch
from
0e68ad0 to
8dbabb2
Compare
names condense comment
schrockn
force-pushed
the
refactor-resolve-key-resolution
branch
from
8dbabb2 to
e6f1250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Takes the duplicated logic added in #16751 and consolidates it to a single helper function. There is a surprising amount of incidental complexity in this logic, so stuffing it into a common helper is a win.
I did this as a separate PR so that we can revert it independently in case this introduces a bug in
@asset.How I Tested These Changes
BK