Extract helper function to find all subclasses of a marker interface #16793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
sryza
approved these changes
Sep 27, 2023
| @@ -328,3 +328,16 @@ def check_concurrency_claim( | |||
| if not self._sleep_interval: | |||
| return claim_status | |||
| return claim_status.with_sleep_interval(float(self._sleep_interval)) | |||
|
|
|||
|
|
|||
| def get_all_direct_subclasses_of_marker(marker_interface_cls: Type) -> List[Type]: | |||
There was a problem hiding this comment.
Might want to name this to make it clear that it's looking at Dagster's top-level exports (or allow passing in some object that determines what scope to examine).
There was a problem hiding this comment.
You have very accurately predicted a change I needed to make in the next PR: https://github.com/dagster-io/dagster/pull/16747/files#r1337902867 👍🏻
Will document it better there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This was a useful piece of logic implemented to do metaprogramming tests of our own code artifacts. I'd like to use it to do another test of this nature, so extracting into a helper function.
How I Tested These Changes
BK