[Asset-graph] Chunk requests using new useAssetLiveData hook + Virtualization #16843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the graphql query that backs this? |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 56ed96c. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 56ed96c. |
AssetGraphLiveQuery |
salazarm
changed the title
bengotow
approved these changes
Sep 27, 2023
js_modules/dagster-ui/packages/ui-core/src/asset-graph/SidebarAssetInfo.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-graph/SidebarAssetInfo.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetGraphExplorer.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetGraphExplorer.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-graph/AssetEdges.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-data/AssetLiveDataProvider.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/asset-data/AssetLiveDataProvider.tsx
Show resolved
Hide resolved
salazarm
force-pushed
the
salazarm/asset-graph-chunked-requests
branch
from
d220cf7 to
d0e03b0
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Sep 28, 2023
…lization (#16843) ## Summary & Motivation 1. Update AssetLiveData to observe run events and refresh asset data 2. Update asset-graph to use useAssetLiveData so that it benefits from chunked asset loading ## How I Tested These Changes 1. Test using the refresh functionality provided useAssetLiveData 2. Test that the asset-graph data now loads in chunks 3. Test that asset data refreshes when launching a run and as events come in 4. Rely on existing jest tests for `useAssetLiveData` to make sure core functionality still works https://www.loom.com/share/cfc67d92c87640d7aa04d0fda578707e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
useAssetLiveDatato make sure core functionality still workshttps://www.loom.com/share/cfc67d92c87640d7aa04d0fda578707e