Fix URL link in Backfill toast in path-prefix case #16954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit fee35c4. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 38485ea. |
salazarm
force-pushed
the
salazarm/backfill-url
branch
from
fee35c4 to
38485ea
Compare
This was
linked to
issues
Oct 2, 2023
hellendag
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Currently BackfillMessage passes
hrefdirectly to Blueprints toaster without accounting for the basepath of the app. UsingHistory.createHrefHow I Tested These Changes
dagster-webserver -p 4444 --path-prefix=/testI created a backfill and clicked the link and saw that the path prefix was used.