[ui] Fix config dialog scrolling #16975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 8158299. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 8158299. |
yuhan
pushed a commit
that referenced
this pull request
Oct 3, 2023
## Summary & Motivation Some recent CodeMirror changes led to the config dialogs being unscrollable. Repair this by setting a height and overflow style on the CodeMirror target div. ## How I Tested These Changes View config dialogs (code location config, run config), Deployment configuration page, launchpad. Verify that CodeMirror containers are properly scrollable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Some recent CodeMirror changes led to the config dialogs being unscrollable. Repair this by setting a height and overflow style on the CodeMirror target div.
How I Tested These Changes
View config dialogs (code location config, run config), Deployment configuration page, launchpad. Verify that CodeMirror containers are properly scrollable.