Update sensor page to be in line with AMP page #17154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit ee1cfc8. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit ee1cfc8. |
bengotow
approved these changes
Oct 13, 2023
js_modules/dagster-ui/packages/ui-core/src/instigation/TickDetailsDialog.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/instigation/TickDetailsDialog.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/instigation/TickDetailsDialog.tsx
Outdated
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/instigation/LiveTickTimeline2.tsx
Show resolved
Hide resolved
salazarm
force-pushed
the
salazarm/update-sensor-page
branch
from
f43f35c to
4dce647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We want to use the same language and visual style for the AMP and Sensor page, these changes will bring them closer to each other, based off this figma: https://www.figma.com/file/ngfhVNvNQxkZ9OV8QVuHzR/AMP%2FSensors-UI?node-id=604%3A26884&mode=dev
How I Tested These Changes
Locally:
