Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipes] docs: add tests for pipes code snippets #17184

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

yuhan
Copy link
Contributor

@yuhan yuhan commented Oct 12, 2023

Summary & Motivation

follow up #17108 (comment) - this PR adds test cases for making sure the code snippets mentioned in pipes subprocess section can load and can execute

How I Tested These Changes

unit test

@yuhan
Copy link
Contributor Author

yuhan commented Oct 12, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@yuhan yuhan force-pushed the 10-12-_pipes_docs_add_tests_for_pipes_code_snippets branch from 32b5b45 to 2bc5976 Compare October 16, 2023 19:43
@github-actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-h2hu1hy43-elementl.vercel.app
https://10-12--pipes-docs-add-tests-for-pipes-code-snippets.components-storybook.dagster-docs.io

Built with commit 2bc5976.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-p116g18li-elementl.vercel.app
https://10-12--pipes-docs-add-tests-for-pipes-code-snippets.core-storybook.dagster-docs.io

Built with commit 2bc5976.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

@yuhan yuhan merged commit 218de55 into master Oct 17, 2023
3 checks passed
@yuhan yuhan deleted the 10-12-_pipes_docs_add_tests_for_pipes_code_snippets branch October 17, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants