[quick] Fix context methods in email on failure sensor #17367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
jamiedemaria
changed the title
jamiedemaria
force-pushed
the
jamie/email-failure-sensor-bug
branch
from
4ac3ff2 to
e604bfa
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit e604bfa. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit e604bfa. |
yuhan
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
make_email_on_run_failure_sensorwas using old context methodpipeline_runthat is no longer on the context. This replaces withdagster_run.How I Tested These Changes
I couldn't find a unit test for these functions, but i successfully ran the sensor locally and received the expected email