add partition_keys property to context #17444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
sryza
reviewed
Oct 27, 2023
python_modules/dagster/dagster/_core/execution/context/compute.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/execution/context/compute.py
Outdated
Show resolved
Hide resolved
jamiedemaria
force-pushed
the
jamie/partition_keys
branch
from
88989cc to
109c4c7
Compare
sryza
approved these changes
Oct 27, 2023
python_modules/dagster/dagster/_core/execution/context/compute.py
Outdated
Show resolved
Hide resolved
python_modules/dagster/dagster/_core/execution/context/compute.py
Outdated
Show resolved
Hide resolved
jamiedemaria
force-pushed
the
jamie/partition_keys
branch
from
109c4c7 to
4469d08
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 4469d08. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 4469d08. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
context.partition_keysis mentioned in the backfill docs, but doesn't exist onOpExecutionContext. This adds the methodHow I Tested These Changes
is there a specific file where the partition methods on the context are tested? otherwise I'll put something in
test_partitioned_assets.py