Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[execute_job] tidy up rexecution from failure #17666

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[execute_job] tidy up rexecution from failure #17666

merged 1 commit into from
Dec 6, 2023

Conversation

alangenfeld
Copy link
Member

Bumped up against this, had an idea for how to resolve it and reduce the number of callsites where we build execution state.

How I Tested These Changes

existing tests

@alangenfeld
Copy link
Member Author

alangenfeld commented Nov 2, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alangenfeld alangenfeld force-pushed the al/11-02-_execute_job_tidy_up_rexecution_from_failure branch from d72de65 to 54274dd Compare November 3, 2023 20:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-h2q4ctjzu-elementl.vercel.app
https://al-11-02--execute-job-tidy-up-rexecution-from-failure.dagster.dagster-docs.io

Direct link to changed pages:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-o5dfmnbp9-elementl.vercel.app
https://al-11-02--execute-job-tidy-up-rexecution-from-failure.core-storybook.dagster-docs.io

Built with commit 23ea863.
This pull request is being automatically deployed with vercel-action

@alangenfeld alangenfeld force-pushed the al/11-02-_execute_job_tidy_up_rexecution_from_failure branch from 54274dd to 7b3cb85 Compare November 28, 2023 18:45
@alangenfeld alangenfeld requested a review from dpeng817 November 28, 2023 18:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-qb5d32k5n-elementl.vercel.app
https://al-11-02--execute-job-tidy-up-rexecution-from-failure.components-storybook.dagster-docs.io

Built with commit 23ea863.
This pull request is being automatically deployed with vercel-action

dpeng817
dpeng817 reviewed Dec 5, 2023
View reviewed changes
python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_retry_execution.py Outdated
@@ -807,6 +807,7 @@ def test_retry_early_terminate(self, graphql_context: WorkspaceRequestContext):
}
},
)
print("WHEW", result)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably remove this one yea?

dpeng817
dpeng817 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@dpeng817 dpeng817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@alangenfeld alangenfeld force-pushed the al/11-02-_execute_job_tidy_up_rexecution_from_failure branch from 7b3cb85 to 23ea863 Compare December 5, 2023 17:59
@alangenfeld alangenfeld merged commit 5a392f8 into master Dec 6, 2023
3 checks passed
@alangenfeld alangenfeld deleted the al/11-02-_execute_job_tidy_up_rexecution_from_failure branch December 6, 2023 19:52
zyd14 pushed a commit to zyd14/dagster that referenced this pull request Jan 20, 2024
@alangenfeld @zyd14
[execute_job] tidy up rexecution from failure (dagster-io#17666)
1d7fbfc 
Bumped up against this, had an idea for how to resolve it and reduce the
number of callsites where we build execution state.

## How I Tested These Changes

existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpeng817 dpeng817 dpeng817 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alangenfeld @dpeng817