Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge icon + use src attribute for search icon #17685

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Nov 3, 2023

Summary & Motivation

As titled

Copy link

github-actions bot commented Nov 3, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-auet54p6e-elementl.vercel.app
https://salazarm-add-badge.components-storybook.dagster-docs.io

Built with commit 474c294.
This pull request is being automatically deployed with vercel-action

@@ -25,7 +25,7 @@ export const GlobalPopoverStyle = createGlobalStyle`
width: 16px;
height: 16px;
background: ${Colors.Gray900};
mask-image: url(${searchSVG});
mask-image: url(${searchSVG.src});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iiiinteresting, I think that DagsterCodeMirrorStyle does this too and may also be broken 👀

@salazarm salazarm merged commit be528ec into master Nov 6, 2023
1 check passed
@salazarm salazarm deleted the salazarm/add-badge branch November 6, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants