[ui] Menu divider header text #17853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
Looks like there aren't really any other use cases of |
|
Looks great! |
leahpadgett
approved these changes
Nov 9, 2023
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 78ee0e8. |
salazarm
approved these changes
Nov 9, 2023
salazarm
pushed a commit
that referenced
this pull request
Nov 9, 2023
## Summary & Motivation A little bit cleaner style for the MenuDivider title text. The current style has awkward spacing, and the bold text makes it look like it could be a clickable item when it's not. Before: <img width="456" alt="Screenshot 2023-11-09 at 8 53 57 AM" src="https://github.com/dagster-io/dagster/assets/2823852/416b9834-07e8-4fe2-b566-4e47f049cfb5"> After: <img width="514" alt="Screenshot 2023-11-09 at 8 46 27 AM" src="https://github.com/dagster-io/dagster/assets/2823852/3f955495-84bf-4ced-ab1d-dcc80b67f3b5"> Storybook (with items that have icons): <img width="209" alt="Screenshot 2023-11-09 at 8 56 45 AM" src="https://github.com/dagster-io/dagster/assets/2823852/73d555a7-eafd-4b88-8d84-a89a855b1040"> ## How I Tested These Changes View Storybook example and Cloud feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
A little bit cleaner style for the MenuDivider title text. The current style has awkward spacing, and the bold text makes it look like it could be a clickable item when it's not.
Before:
After:
Storybook (with items that have icons):
How I Tested These Changes
View Storybook example and Cloud feature.