[ui] Experimental asset Overview page #19739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit cd94274. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit cd94274. |
bengotow
force-pushed
the
bengotow-2024-02/FE-174
branch
3 times, most recently
from
96b7eed to
5f88dfb
Compare
salazarm
reviewed
Feb 13, 2024
js_modules/dagster-ui/packages/ui-core/src/asset-graph/sidebar/Sidebar.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Feb 13, 2024
js_modules/dagster-ui/packages/ui-core/src/asset-graph/sidebar/StatusDot.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Feb 13, 2024
js_modules/dagster-ui/packages/ui-core/src/assets/AssetEventMetadataEntriesTable.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Feb 13, 2024
js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeDefinition.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Feb 13, 2024
js_modules/dagster-ui/packages/ui-core/src/assets/AssetEventMetadataEntriesTable.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Feb 13, 2024
js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeOverview.tsx
Outdated
Show resolved
Hide resolved
salazarm
reviewed
Feb 13, 2024
salazarm
approved these changes
Feb 13, 2024
bengotow
force-pushed
the
bengotow-2024-02/FE-174
branch
from
a04b16c to
0fb44ef
Compare
bengotow
force-pushed
the
bengotow-2024-02/FE-174
branch
from
0fb44ef to
6d40c09
Compare
jmsanders
pushed a commit
that referenced
this pull request
Feb 13, 2024
## Summary & Motivation - New asset overview page is hidden behind the existing "new AMP page" feature flag, which has been renamed in the UI. - Figma: https://www.figma.com/file/wQHGZ2cjfpna2P2OaM4aTs/aset-catalog-ui?type=design&node-id=208-45869&mode=design&t=rUdPOq932g3jaHWh-0 - Linear: https://linear.app/dagster-labs/issue/FE-174/implement-new-asset-overview-designs ## TODOs / Further work: - The top header is unchanged - In the sidebar, code location does not use a tag ## How I Tested These Changes Tested manually with a number of different assets in different states  --------- Co-authored-by: bengotow <[email protected]> (cherry picked from commit b3a1f2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
TODOs / Further work:
How I Tested These Changes
Tested manually with a number of different assets in different states