Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggest component] Allow adding icon to Suggest #19801

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

salazarm
Copy link
Contributor

Summary & Motivation

as titled

How I Tested These Changes

storybook
Screenshot 2024-02-14 at 2 48 29 PM
Screenshot 2024-02-14 at 2 48 25 PM

@salazarm salazarm requested review from bengotow and prha February 14, 2024 19:48
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-en4xi88i8-elementl.vercel.app
https://salazarm-icon-suggest.components-storybook.dagster-docs.io

Built with commit ca5ffac.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm merged commit 85d7587 into master Feb 14, 2024
2 checks passed
@salazarm salazarm deleted the salazarm/icon-suggest branch February 14, 2024 20:18
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
## Summary & Motivation
as titled

## How I Tested These Changes
storybook
<img width="309" alt="Screenshot 2024-02-14 at 2 48 29 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/e99822a9-d6ef-492a-b6de-473d68e8083b">
<img width="337" alt="Screenshot 2024-02-14 at 2 48 25 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/9e22011c-5c6e-4bcb-ab2f-2100493a0869">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants