[bugfix] asset owner copying #19880
Merged
[bugfix] asset owner copying #19880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smackesey
force-pushed
the
sean/fix-asset-owner-copying
branch
from
0fd5f34 to
44b4cc7
Compare
This was referenced Feb 17, 2024
smackesey
force-pushed
the
sean/fix-asset-owner-copying
branch
from
44b4cc7 to
a613a50
Compare
smackesey
force-pushed
the
sean/fix-asset-owner-copying
branch
2 times, most recently
from
272f436 to
671dd81
Compare
rexledesma
approved these changes
Feb 20, 2024
| @@ -2062,9 +2062,9 @@ def test_asset_owners(): | |||
| def my_asset(): | |||
| pass | |||
|
|
|||
| assert my_asset.owners_by_key == { | |||
There was a problem hiding this comment.
In my_asset, can we also test passing in TeamAssetOwner and UserAssetOwner instantiated objects?
smackesey
force-pushed
the
sean/fix-asset-owner-copying
branch
from
671dd81 to
af90902
Compare
|
@smackesey thanks for fixing this 🙌 |
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation
The recently added `owners_by_key` field on `AssetsDefinition` breaks
when copying an `AssetsDefinition`. Calling `with_attributes` on an
`AssetDefinition` that had defined assets owners would trigger a runtime
error due to performance of string operations on `{Team,User}AssetOwner`
objects. Also the type annotation was incorrect for `owners_by_key`.
This fixes the bug.
## How I Tested These Changes
Add test for copying owners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The recently added
owners_by_keyfield onAssetsDefinitionbreaks when copying anAssetsDefinition. Callingwith_attributeson anAssetDefinitionthat had defined assets owners would trigger a runtime error due to performance of string operations on{Team,User}AssetOwnerobjects. Also the type annotation was incorrect forowners_by_key. This fixes the bug.How I Tested These Changes
Add test for copying owners.