Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix PyObject references for PipesLambdaClient (DOC-147) #19919

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

cmpadden
Copy link
Contributor

Summary & Motivation

The links were broken for two reasons:

  1. PyObject was referencing dagster_aws and not dagster_aws.pipes
  2. dagster_aws.pipes was not registered in the Sphinx configuration

This pull request does the following:

  • Fixes PyObject references to PipesLambdaClient
  • Include PipesLambdaClient in Sphinx definition
  • Run make apidoc-build

How I Tested These Changes

Ran make next-watch-build and confirmed links worked as expected.

Resolves DOC-147.

@cmpadden cmpadden requested a review from tacastillo February 21, 2024 15:08
@erinkcochran87 erinkcochran87 changed the title [docs] fix PyObject references for PipesLambdaClient [docs] fix PyObject references for PipesLambdaClient (DOC-147) Feb 21, 2024
@erinkcochran87 erinkcochran87 added the area: docs Related to documentation in general label Feb 21, 2024
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cmpadden cmpadden merged commit 819ec68 into master Feb 21, 2024
2 checks passed
@cmpadden cmpadden deleted the colton/fix-pipeslambdaclient-pyobject branch February 21, 2024 21:07
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
)

## Summary & Motivation

The links were broken for two reasons:

1. `PyObject` was referencing `dagster_aws` and not `dagster_aws.pipes`
2. `dagster_aws.pipes` was not registered in the Sphinx configuration

This pull request does the following:

- Fixes PyObject references to PipesLambdaClient
- Include PipesLambdaClient in Sphinx definition
- Run `make apidoc-build`

## How I Tested These Changes

Ran `make next-watch-build` and confirmed links worked as expected.

Resolves DOC-147.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants