[dagster-fivetran] tests tweak to avoid duplicate asset keys #19920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This was referenced Feb 20, 2024
OwenKephart
approved these changes
Feb 20, 2024
smackesey
force-pushed
the
sean/fivetran-tests-tweak
branch
from
1d6e2ce to
ae91a5a
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation See https://github.com/dagster-io/dagster/pull/19879/files#r1493423916 for context. Some `dagster-fivetran` tests create duplicate asset keys when using multiple connectors. This changes the tests to use unique asset keys. ## How I Tested These Changes The tests still pass (and also pass upstack where they started failing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
See https://github.com/dagster-io/dagster/pull/19879/files#r1493423916 for context.
Some
dagster-fivetrantests create duplicate asset keys when using multiple connectors. This changes the tests to use unique asset keys.How I Tested These Changes
The tests still pass (and also pass upstack where they started failing).