-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asset checks UI revamp #19934
Merged
salazarm
merged 11 commits into
master
from
marco/fe-170-asset-checks-ui-20-converted-to-asset-checks-ui-20-project
Feb 23, 2024
Merged
Asset checks UI revamp #19934
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
87fbdea
so far
salazarm 1e8f5ec
asset checks revamp
salazarm 2f1ff45
rm console.logs
salazarm 36d238c
Merge branch 'master' of github.com:dagster-io/dagster into marco/fe-…
salazarm 9948bd6
update fixtures
salazarm ce77855
.
salazarm 75b4e48
more builders
salazarm 1e3fced
update fixtures
salazarm 39fe49f
update test
salazarm a781779
regenerate graphql
salazarm 80bcf6e
feedback
salazarm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
37 changes: 37 additions & 0 deletions
37
js_modules/dagster-ui/packages/ui-components/src/components/CollapsibleSection.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import React from 'react'; | ||
|
||
import {Box} from './Box'; | ||
import {Icon} from './Icon'; | ||
|
||
export const CollapsibleSection = ({ | ||
header, | ||
headerWrapperProps, | ||
children, | ||
isInitiallyCollapsed = false, | ||
}: { | ||
header: React.ReactNode; | ||
headerWrapperProps?: React.ComponentProps<typeof Box>; | ||
children: React.ReactNode; | ||
isInitiallyCollapsed?: boolean; | ||
}) => { | ||
const [isCollapsed, setIsCollapsed] = React.useState(isInitiallyCollapsed); | ||
return ( | ||
<Box flex={{direction: 'column'}}> | ||
<Box | ||
{...headerWrapperProps} | ||
flex={{direction: 'row', alignItems: 'center', gap: 6, ...(headerWrapperProps?.flex || {})}} | ||
onClick={() => { | ||
setIsCollapsed(!isCollapsed); | ||
headerWrapperProps?.onClick?.(); | ||
}} | ||
> | ||
<Icon | ||
name="arrow_drop_down" | ||
style={{transform: isCollapsed ? 'rotate(-90deg)' : 'rotate(0deg)'}} | ||
/> | ||
<div>{header}</div> | ||
</Box> | ||
{isCollapsed ? null : children} | ||
</Box> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
js_modules/dagster-ui/packages/ui-core/src/asset-graph/types/SidebarAssetInfo.types.ts
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm does this one look like the new Asset Overview one? (the "Description" header here: https://www.figma.com/file/wQHGZ2cjfpna2P2OaM4aTs/aset-catalog-ui?type=design&node-id=208-45868&mode=design&t=IUz5OJkO0QRbYlOv-0)
Maybe we can merge this one and that together. I'd left it in the AssetNodeOverview.tsx file because there weren't any other collapsing sections like that in the product, but maybe there are now!