Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Hello, Dagster becomes Quickstart #19981
[docs] Hello, Dagster becomes Quickstart #19981
Changes from all commits
ce5ace6
1e386c6
0381dad
e4596aa
2a1a6aa
cde01c4
b4cc6b6
fe8ab01
a68cf4f
02e5b74
5b22aae
02a9860
61cc767
27bddb1
e8a7b47
ef00023
633caf1
21a33f9
e336b52
5f95467
26b9d28
2b0dcd8
3edcd0f
60c7392
89cd315
15b35c3
2a93499
12e6be4
c5d7b2f
34029cf
ae3487d
58dafaa
fd63267
2e0c05f
1582cdc
79a731f
44b961c
5051186
3539913
2f060c4
1c9759c
f42149b
5f13b66
1211b05
f7aa3fe
a916847
596a97d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[1], and this becomes an H2 with the removal of the
# Introduction
heading.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - this sounds like the next paragraph will be the command, but it's more explanation. I suggest moving things around a bit:
Double-check the formatting if you accept this suggestion - GH can be cranky about code blocks within code blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Becomes an H2 with the removal of
# Introduction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a period to make this consistent with other list items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[2] This image isn't nested under the list item about it (
2
). Indent everything (I think it's 3 spaces; if not that, then 4) and everything should be in lineThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[2]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[3] We use horizontal rules before every H2.
Also making this heading more specific by including the proper name of the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a period and including the name of the asset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[2]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[3] and using sentence casing