[external-assets] Cache asset key subsets in refactored AssetGraph #20059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
smackesey
force-pushed
the
sean/external-assets-cache-key-subsets
branch
from
1f12ecc to
4140091
Compare
gibsondan
approved these changes
Feb 26, 2024
|
The bottleneck was entirely regenerating
I think these are already quite fast |
cmpadden
pushed a commit
that referenced
this pull request
Feb 28, 2024
…20059) ## Summary & Motivation #19900 led to an auto-materialize performance regression caught by our regression tests. After investigating with a profiler, I found the issue was lack of caching on asset key subset methods in the new `AssetGraph`. This PR adds them. ## How I Tested These Changes Ran perf regression tests against this branch.
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
…20059) ## Summary & Motivation #19900 led to an auto-materialize performance regression caught by our regression tests. After investigating with a profiler, I found the issue was lack of caching on asset key subset methods in the new `AssetGraph`. This PR adds them. ## How I Tested These Changes Ran perf regression tests against this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
#19900 led to an auto-materialize performance regression caught by our regression tests. After investigating with a profiler, I found the issue was lack of caching on asset key subset methods in the new
AssetGraph. This PR adds them.How I Tested These Changes
Ran perf regression tests against this branch.