[external-assets] Change error to warning for duplicate assets when constructing ExternalAssetGraph #20062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
smackesey
force-pushed
the
sean/external-assets-duplicate-error-message
branch
from
7445c24 to
36d7eb7
Compare
smackesey
changed the title
alangenfeld
approved these changes
Feb 26, 2024
Comment on lines
+404
to
+407
| warnings.warn( | ||
| f"Found {execution_type.value} nodes for some asset keys in multiple code locations." | ||
| f" Only one {execution_type.value} node is allowed per asset key. Duplicates:\n {duplicate_str}" | ||
| ) |
There was a problem hiding this comment.
echoing a concern raised in discussions else where so its recorded here
I think this will only show up in the daemon / webserver, which a user might catch in local dev but in a deployed contex is unlikely to be observed. Improving that effectively requires some UI surface area to highlight these global asset graph problems, much like we have talked about in the past for cycles.
There was a problem hiding this comment.
Raising this here: https://dagsterlabs.slack.com/archives/C03CCE471E0/p1708978938397619
cmpadden
pushed a commit
that referenced
this pull request
Feb 28, 2024
…onstructing ExternalAssetGraph (#20062) ## Summary & Motivation #19900 introduced a check in the construction of `ExternalAssetGraph` that would throw an error if two materializable or observable defs having the same key were detected in a deployment (this is an invalid state). However, after running a shadow script against customer deployments, I discovered that ~3% of active deployments have this problem, so I am changing it to a warning (and making the message more informative) until we can find a clean strategy to message our customers who have this problem. ## How I Tested These Changes New test.
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
…onstructing ExternalAssetGraph (#20062) ## Summary & Motivation #19900 introduced a check in the construction of `ExternalAssetGraph` that would throw an error if two materializable or observable defs having the same key were detected in a deployment (this is an invalid state). However, after running a shadow script against customer deployments, I discovered that ~3% of active deployments have this problem, so I am changing it to a warning (and making the message more informative) until we can find a clean strategy to message our customers who have this problem. ## How I Tested These Changes New test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
#19900 introduced a check in the construction of
ExternalAssetGraphthat would throw an error if two materializable or observable defs having the same key were detected in a deployment (this is an invalid state). However, after running a shadow script against customer deployments, I discovered that ~3% of active deployments have this problem, so I am changing it to a warning (and making the message more informative) until we can find a clean strategy to message our customers who have this problem.How I Tested These Changes
New test.