Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset checks polish #20263

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Asset checks polish #20263

merged 5 commits into from
Mar 6, 2024

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Mar 5, 2024 •
edited
Loading

Summary & Motivation

Screenshot 2024-03-05 at 1 42 03 PM
  1. Lowercase "result" in "Evaluation result".
  2. Move the collapse arrows to the right side
  3. Don't show the latest execution in the table since we already show it above

How I Tested These Changes

@salazarm salazarm requested review from sryza, bengotow and hellendag March 5, 2024 18:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-kbtdv0l1w-elementl.vercel.app
https://salaarm-asset-checks-polish.components-storybook.dagster-docs.io

Built with commit d9b9f93.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-4i1n9af5g-elementl.vercel.app
https://salaarm-asset-checks-polish.core-storybook.dagster-docs.io

Built with commit d9b9f93.
This pull request is being automatically deployed with vercel-action

@sryza
Copy link
Contributor

sryza commented Mar 5, 2024

This version of the design has the metadata fields for the latest check evaluation in their own table, rather than gated by a modal:

image

https://dagsterlabs.slack.com/archives/C03CCE471E0/p1709310817804649?thread_ts=1709310142.884309&cid=C03CCE471E0

I like that direction, because it necessitates fewer clicks to get to the data that gives context to the check. Any reservations about this @salazarm? cc @braunjj in case I am missing a later version of the design.

bengotow
bengotow approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@bengotow bengotow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@braunjj
Copy link
Contributor

braunjj commented Mar 6, 2024

Love it

@salazarm
Copy link
Contributor Author

salazarm commented Mar 6, 2024

@sryza updated:
Screenshot 2024-03-06 at 3 07 13 PM

@salazarm salazarm merged commit 5487ee2 into master Mar 6, 2024
3 checks passed
@salazarm salazarm deleted the salaarm/asset-checks-polish branch March 6, 2024 20:59
dpeng817 pushed a commit that referenced this pull request Mar 6, 2024
@salazarm @dpeng817
Asset checks polish (#20263)
05dab31 
## Summary & Motivation
<img width="1727" alt="Screenshot 2024-03-05 at 1 42 03 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/e1f51883-2b00-4d49-be73-f16c6c2f821b">

1. Lowercase "result" in "Evaluation result".
2. Move the collapse arrows to the right side
3. Don't show the latest execution in the table since we already show it
above

## How I Tested These Changes
dpeng817 pushed a commit that referenced this pull request Mar 6, 2024
@salazarm @dpeng817
Asset checks polish (#20263)
70d9bd0 
## Summary & Motivation
<img width="1727" alt="Screenshot 2024-03-05 at 1 42 03 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/e1f51883-2b00-4d49-be73-f16c6c2f821b">

1. Lowercase "result" in "Evaluation result".
2. Move the collapse arrows to the right side
3. Don't show the latest execution in the table since we already show it
above

## How I Tested These Changes
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
@salazarm @PedramNavid
Asset checks polish (#20263)
4f294f7 
## Summary & Motivation
<img width="1727" alt="Screenshot 2024-03-05 at 1 42 03 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/e1f51883-2b00-4d49-be73-f16c6c2f821b">

1. Lowercase "result" in "Evaluation result".
2. Move the collapse arrows to the right side
3. Don't show the latest execution in the table since we already show it
above

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengotow bengotow bengotow approved these changes

@sryza sryza Awaiting requested review from sryza

@hellendag hellendag Awaiting requested review from hellendag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salazarm @sryza @braunjj @bengotow