[ui] Add tests for recently visited assets #20321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @clairelin135 and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5718898. |
clairelin135
force-pushed
the
03-04-claire/recently-visited-history
branch
from
f64b3fc to
0e3f279
Compare
clairelin135
force-pushed
the
03-06-claire/add-tests-recently-visited
branch
from
4be4ae9 to
402da36
Compare
clairelin135
force-pushed
the
03-04-claire/recently-visited-history
branch
from
0e3f279 to
cf105b2
Compare
clairelin135
force-pushed
the
03-06-claire/add-tests-recently-visited
branch
from
402da36 to
8513e6c
Compare
salazarm
reviewed
Mar 7, 2024
| await waitFor(() => { | ||
| expect(screen.queryByText('Loading assets…')).toBeNull(); | ||
| }); | ||
| // Second render displays the page in a loaded state |
There was a problem hiding this comment.
expect(fetchRecentlyVisitedAssetsFromLocalStorage()).toEqual([]); to confirm it doesn't save it until after the loading finishes
salazarm
approved these changes
Mar 7, 2024
clairelin135
force-pushed
the
03-04-claire/recently-visited-history
branch
from
cf105b2 to
bfc4326
Compare
clairelin135
force-pushed
the
03-06-claire/add-tests-recently-visited
branch
from
8513e6c to
bc3d7f2
Compare
salazarm
reviewed
Mar 7, 2024
| assetKey, | ||
| }, | ||
| data: { | ||
| assetOrError: { |
There was a problem hiding this comment.
buildAssetNotFoundError for next time
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
Adds tests to preserve logic in #20266 that stores the N most recently-viewed assets: - Assert that when an asset is viewed, its asset key is stored in local storage - Assert that if a user tries to view a nonexistent asset, nothing is added to local storage Let me know if more detailed tests are needed, i.e. tests asserting LRU cache behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to preserve logic in #20266 that stores the N most recently-viewed assets:
Let me know if more detailed tests are needed, i.e. tests asserting LRU cache behavior.